implement the new mDNS spec, move the old mDNS implementation #1161
Conversation
p2p/discovery/mdns.go
Outdated
| s.mdnsInstance(), | ||
| s.serviceName, | ||
| mdnsDomain, | ||
| 4001, |
There was a problem hiding this comment.
Can we leave a comment saying "this port doesn't actually matter, only the TXT records are used?"
There was a problem hiding this comment.
Does this need to be lower case?
There was a problem hiding this comment.
Done. Not sure what you're referring to when you ask about lower case.
There was a problem hiding this comment.
Ah, sorry, commented on the wrong line. I was referring to the peer ID in the line below.
p2p/discovery/mdns.go
Outdated
| s.mdnsInstance(), | ||
| s.serviceName, | ||
| mdnsDomain, | ||
| 4001, |
There was a problem hiding this comment.
Ah, sorry, commented on the wrong line. I was referring to the peer ID in the line below.
p2p/mdns/mdns.go
Outdated
| @@ -0,0 +1,216 @@ | |||
| package mdns | |||
There was a problem hiding this comment.
I was actually thinking discovery/mdns to better organize the packages. But this also works.
There was a problem hiding this comment.
Yes, that's better. Let's do that.
Closes #1125. Fixes #176. Fixes #253. Fixes #623. Probably fixes #894. Probably fixes #469.